linux-kernel - Re: [PATCH resend 0/2] I2C: sis630: add sis964 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121218125105.25c2cbb6@endymion.delvare>
Date:	Tue, 18 Dec 2012 12:51:05 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Amaury Decrême <amaury.decreme@...il.com>
Cc:	"Wolfram Sang" <w.sang@...gutronix.de>, nelson@....com,
	mhoffman@...htlink.com, amalysh@....de, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend 0/2] I2C: sis630: add sis964 support

Hi Amaury,

On Wed, 29 Aug 2012 03:35:13 +0200, Amaury Decrême wrote:
> This serie of patches brings SIS964 support to i2c-sis630.
> 
> The SiS datasheets have been used.
> 
> The SIS964 isn't part of the SIS96X family and behaves differently.
> For i2c, this array show the differences between sis630 and sis964.
> 	+------------------------+--------------------+-------------------+
> 	|                        |     SIS630/730     |      SIS964       |
> 	+------------------------+--------------------+-------------------+
> 	| Clock                  | 14kHz/56kHz        | 55.56kHz/27.78kHz |
> 	| SMBus registers offset | 0x80               | 0xE0              |
> 	| SMB_CNT                | Bit 1 = Slave Busy | Bit 1 = Bus probe |
> 	| SMB_COUNT              | 4:0 bits           | 5:0 bits          |
> 	+------------------------+--------------------+-------------------+
> 
> The other differences doesn't affect the functions provided by the original
> i2c-sis630 driver.
> 
> The first patch is mandatory as it adds supports for SIS964 bus.
> The second patch is optional. It depends on the first patch.
> 
> Amaury Decrême (2):
>   I2C: sis630: sis964 bus
>   I2C: sis630: Cleaning and cosmetics
> 
>  Documentation/i2c/busses/i2c-sis630 |   17 +-
>  drivers/i2c/busses/Kconfig          |    4 +-
>  drivers/i2c/busses/i2c-sis630.c     |  445 +++++++++++++++++++++--------------
>  3 files changed, 278 insertions(+), 188 deletions(-)

I reviewed these two patches 2 months ago, but did not hear back from
you since then. Do you plan to resubmit these patches with the
improvements I suggested? I would hate to see your work time and mine
wasted.

Thanks,
-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/