linux-kernel - Re: [PATCH v2 0/6] fuse: process direct IO asynchronously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50D07A45.3080809@redhat.com>
Date:	Tue, 18 Dec 2012 09:14:29 -0500
From:	Brian Foster <bfoster@...hat.com>
To:	"Maxim V. Patlasov" <MPatlasov@...allels.com>
CC:	miklos@...redi.hu, dev@...allels.com, xemul@...allels.com,
	fuse-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	devel@...nvz.org
Subject: Re: [PATCH v2 0/6] fuse: process direct IO asynchronously

On 12/14/2012 10:20 AM, Maxim V. Patlasov wrote:
> Hi,
> 
...
> The throughput on some commodity (rather feeble) server was (in MB/sec):
> 
>              original / patched
> 
> dd reads:    ~322     / ~382
> dd writes:   ~277     / ~288
> 
> aio reads:   ~380     / ~459
> aio writes:  ~319     / ~353
> 
> Changed in v2 - cleanups suggested by Brian:
>  - Updated fuse_io_priv with an async field and file pointer to preserve
>    the current style of interface (i.e., use this instead of iocb).
>  - Trigger the type of request submission based on the async field.
>  - Pulled up the fuse_write_update_size() call out of __fuse_direct_write()
>    to make the separate paths more consistent.
> 

This version plus the updated "fuse: truncated file if async dio failed
- v2" patch address all the questions I had on the set, so consider it:

Reviewed-by: Brian Foster <bfoster@...hat.com>

I also ran some of your aio/dio performance tests on a basic gluster
volume (single client to server) and repeated positive results. The
results include rewrite numbers (file extending writes generally matched
original throughput). Results in MB/s:

		original / patched
1GigE
dd reads:	~74	/	~104
dd rewrites:	~67	/	~103
aio reads:	~53	/	~110
aio rewrites:	~52	/	~112

10GigE
dd reads:	~175	/	~437
dd rewrites:	~134	/	~390
aio reads:	~84	/	~417
aio rewrites:	~88	/	~401

Brian

> Thanks,
> Maxim
> 
> ---
> 
> Maxim V. Patlasov (6):
>       fuse: move fuse_release_user_pages() up
>       fuse: add support of async IO
>       fuse: make fuse_direct_io() aware about AIO
>       fuse: enable asynchronous processing direct IO
>       fuse: truncate file if async dio failed
>       fuse: optimize short direct reads
> 
> 
>  fs/fuse/cuse.c   |    6 +
>  fs/fuse/file.c   |  290 +++++++++++++++++++++++++++++++++++++++++++++++-------
>  fs/fuse/fuse_i.h |   19 +++-
>  3 files changed, 276 insertions(+), 39 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/