[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <6433.1355840610@warthog.procyon.org.uk>
Date: Tue, 18 Dec 2012 14:23:30 +0000
From: David Howells <dhowells@...hat.com>
To: Joe Perches <joe@...ches.com>,
Marcelo Tosatti <mtosatti@...hat.com>
cc: dhowells@...hat.com, Alexander Graf <agraf@...e.de>,
linux-kernel@...r.kernel.org
Subject: checkpatch.pl should check UAPI headers don't #include <uapi/...>
Hi Joe,
Can you make checkpatch.pl check that lines added to UAPI headers don't have
the form:
#include <uapi/...>
or:
#include "uapi/..."
Such as these should be regarded as errors as they will likely break userspace
which shouldn't get to see any uapi/ directories.
An example of this is in:
commit 19bf7f8ac3f8131100027281c495dbbe00cd5ae0
Merge: 787c57c 35fd3dc
Author: Marcelo Tosatti <mtosatti@...hat.com>
Date: Mon Oct 29 19:15:32 2012 -0200
where during the conflict resolution, the following change was made:
- #include <asm/epapr_hcalls.h>
++#include <uapi/asm/epapr_hcalls.h>
I recognise that checkpatch.pl might not have helped in this case since it
isn't normally applied to merged as far as I know.
Thanks,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists