linux-kernel - Re: [PATCH] cifs: Do not enable debugging code by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121218100702.478fc1b1@tlielax.poochiereds.net>
Date:	Tue, 18 Dec 2012 10:07:02 -0500
From:	Jeff Layton <jlayton@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Steve French <smfrench@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Joe Perches <joe@...ches.com>,
	Steve French <sfrench@...ba.org>, linux-cifs@...r.kernel.org
Subject: Re: [PATCH] cifs: Do not enable debugging code by default

On Tue, 18 Dec 2012 15:44:52 +0100
Borislav Petkov <bp@...en8.de> wrote:

> On Tue, Dec 18, 2012 at 07:13:17AM -0500, Jeff Layton wrote:
> > I agree that we often need cifsFYI debug info in order to troubleshoot
> > problems. The question here though is whether compiling those in ought
> > to be the default.
> >
> > In generic distro kernels, I think we do want that turned on even in
> > non-debug kernels. On an embedded arch, it's less compelling.
> >
> > Might it make sense to couple this change with a change to the
> > CONFIG_CIFS_DEBUG help text? Something like:
> >
> > "This option defaults to 'N', but enabling this is strongly encouraged
> > unless memory is severely constrained."
> 
> ... or we make it default n if EMBEDDED, otherwise default y + changing
> the help text?
> 
> > Then we can just try to make sure non-embedded distros enable it.
> 
> Yeah, I don't think distros look at the help text... or?
> 

Yeah, not many do, but presumably they'll set it once and forget about
it. Once someone straightens them out, they should rarely break.

OTOH, the value of defaulting to "N" is pretty low here. Maybe it would
just be best to just drop this patch and have the embedded folks turn
this off on their own.

-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/