linux-kernel - Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121218152623.GA26077@sirena.org.uk>
Date:	Tue, 18 Dec 2012 15:26:26 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jun Chen <jun.d.chen@...el.com>
Cc:	grant.likely@...retlab.ca, linux-kernel@...r.kernel.org,
	Bi Chao <chao.bi@...el.com>,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH] spi: Add the flag indicate to registe new device as
 children of master or not.

On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote:

>   * @master: Controller to which device is connected
> + * device_was_children_of_master is flag which the device is registed
> + * as the children of the bus

This isn't a kerneldoc style comment (it needs the @XXX: format).  The
name is also extremely long, can't we think of something more concise?

> -	spi->dev.parent = &master->dev;
> +	if (device_was_children_of_master == true)
> +		spi->dev.parent = &master->dev;
> +	else
> +		spi->dev.parent = dev;

Can you provide an example of where this is useful?  Your changelog
didn't make it clear and the code doesn't make it obvious either.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/