linux-kernel - Re: [PATCH] HDA: Fix sound resume hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h7gofuyk5.wl%tiwai@suse.de>
Date:	Tue, 18 Dec 2012 17:15:06 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Daniel J Blueman <daniel@...ra.org>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HDA: Fix sound resume hang

At Tue, 18 Dec 2012 23:59:33 +0800,
Daniel J Blueman wrote:
> 
> Resuming a switcheroo'd HDA controller hangs since the completion
> is one-shot (thus works the first time). Fix by using completions
> that explictly need rearming, so remain fired before.
> 
> Signed-off-by: Daniel J Blueman <daniel@...ra.org>

Oops, sorry, this was a forgotten scenario.
This isn't a perfect fix but easy enough and would work practically,
so I applied it now.  Thanks.


Takashi


> ---
>  sound/pci/hda/hda_intel.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 22ecadc..e12b939 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2856,7 +2856,7 @@ static int azx_free(struct azx *chip)
>  	azx_notifier_unregister(chip);
>  
>  	chip->init_failed = 1; /* to be sure */
> -	complete(&chip->probe_wait);
> +	complete_all(&chip->probe_wait);
>  
>  	if (use_vga_switcheroo(chip)) {
>  		if (chip->disabled && chip->bus)
> @@ -3482,7 +3482,7 @@ static int __devinit azx_probe(struct pci_dev *pci,
>  		pm_runtime_put_noidle(&pci->dev);
>  
>  	dev++;
> -	complete(&chip->probe_wait);
> +	complete_all(&chip->probe_wait);
>  	return 0;
>  
>  out_free:
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/