linux-kernel - Re: Strange results of DIV_ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Dec 2012 09:16:20 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Juergen Beisert <jbe@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Strange results of DIV_ROUND_CLOSEST

On Tue, Dec 18, 2012 at 04:03:41PM +0100, Juergen Beisert wrote:
> Hi list,
> 
> commit 263a523d18bca306016d75f5c8d5c57c37fe52fb changes the code of 
> DIV_ROUND_CLOSEST in include/linux/kernel.h to fix a compile time warning.
> 
> But now feeding in a zero into this macro results into 4198403. Tested with 
> gcc 4.4.3 and 4.7.2, on arch x86 and ARM.
> 
> I can reproduce this behaviour, when my ADC delivers a '0' value in the driver 
> drivers/hwmon/s3c-hwmon.c in function s3c_hwmon_ch_show() with a current 
> 3.7.1 kernel. The value is correct again, when the ADC delivers at least 
> a '1'.
> 
> Any ideas how to fix it correctly?
> 
Odd one. I ran the macro through a large number of values and divisors as well
as various optimization options, with different compilers, and always get
correct results.

What are your compile options, and what are the channel multiplier and dividers
set to ?

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/