linux-kernel - Re: [PATCH v2] iio: dac: ad5446: Don't set error code to voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50D0C29D.3030209@kernel.org>
Date:	Tue, 18 Dec 2012 19:23:09 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Jonathan Cameron <jic23@....ac.uk>,
	Michael Hennerich <hennerich@...ckfin.uclinux.org>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: dac: ad5446: Don't set error code to voltage_uv

On 12/18/2012 03:33 AM, Axel Lin wrote:
> regulator_get_voltage() may return negative error code.
> Add error checking to avoid setting error code to voltage_uv.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
added to fixes-togreg branch of iio.git
> ---
> Sorry. Just found I made the same mistake again.
> Here is v2, should check if ret is negative value.
>  drivers/iio/dac/ad5446.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index 3310cbb..607378f 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
>  		if (ret)
>  			goto error_put_reg;
>  
> -		voltage_uv = regulator_get_voltage(reg);
> +		ret = regulator_get_voltage(reg);
> +		if (ret < 0)
> +			goto error_disable_reg;
> +
> +		voltage_uv = ret;
>  	}
>  
>  	indio_dev = iio_device_alloc(sizeof(*st));
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/