linux-kernel - Re: [PATCH] checkpatch: Warn on #include <uapi/...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1355860368.30366.33.camel@joe-AO722>
Date:	Tue, 18 Dec 2012 11:52:48 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Alexander Graf <agraf@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on #include <uapi/...

On Tue, 2012-12-18 at 19:17 +0000, David Howells wrote:
> Joe Perches <joe@...ches.com> wrote:
> 
> > +			if ($path =~ "^uapi/") {
> > +				ERROR("UAPI_INCLUDE",
> > +				      "#include should not start with uapi/\n" . $herecurr);
> >  			}
> 
> But does this limit the check only to headers in uapi/ directories?

No.  I'm confused, I believe your example was:

arch/powerpc/include/asm/kvm_para.h
@@ -16,77 +16,11 @@
  *
  * Authors: Hollis Blanchard <hollisb@...ibm.com>
  */
-
 #ifndef __POWERPC_KVM_PARA_H__
 #define __POWERPC_KVM_PARA_H__
 
-#include <linux/types.h>
+#include <uapi/asm/kvm_para.h>

---------------

What do you want this to check?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/