linux-kernel - Re: [PATCH 1/9] can: add tx/rx LED trigger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92a8e5e68e38c059d3a29b5ed4252da8.squirrel@webmail.universalnet.at>
Date:	Tue, 18 Dec 2012 07:02:02 +0100
From:	"Bernd Krumböck" <krumboeck@...versalnet.at>
To:	"Fabio Baltieri" <fabio.baltieri@...il.com>,
	"Bernd Krumböck" <krumboeck@...versalnet.at>,
	"Marc Kleine-Budde" <mkl@...gutronix.de>,
	linux-can@...r.kernel.org,
	"Kurt Van Dijck" <kurt.van.dijck@....be>,
	"Wolfgang Grandegger" <wg@...ndegger.com>,
	"Oliver Hartkopp" <socketcan@...tkopp.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] can: add tx/rx LED trigger support

Hi Fabio!

> On Mon, Dec 17, 2012 at 09:20:57PM +0100, "Bernd Krumböck" wrote:
>> > If you think it's useful for USB controller, just tell me or modify
>> the
>> > driver by yourself!  As you see the patch is really easy.
>>
>> At least it is useful for the usb_8dev driver. I'll write a patch.
>>
>> Photo of the device:
>> http://www.8devices.com/product/2/usb2can
>
> Sure that it's needed?  That status LED is probably controlled directly
> by the firmware itself.  Anyway I think it makes sense to support all
> the mainline drivers and I'm really happy if you test the patch on
> your hardware!

Yes, it is controlled by the firmware, but it does not show rx/tx. Whereas
my OpenWRT hardware has enough leds. ;-)

regards,
Bernd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/