linux-kernel - Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Dec 2012 01:23:13 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Stephen Boyd <sboyd@...eaurora.org>
cc:	Bob Liu <lliubbo@...il.com>, linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-arm-msm@...r.kernel.org, Steven Miao <realmz6@...il.com>,
	trivial@...nel.org
Subject: Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment

On Tue, 18 Dec 2012, Stephen Boyd wrote:

> It seems that this assignment is done twice in a row. Remove the
> duplicate assignment.
> 
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> Cc: Steven Miao <realmz6@...il.com>
> Cc: trivial@...nel.org
> ---
> 
> Noticed while grepping for broadcast users.
> 
>  arch/blackfin/kernel/time-ts.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
> index f608f02..cb0a484 100644
> --- a/arch/blackfin/kernel/time-ts.c
> +++ b/arch/blackfin/kernel/time-ts.c
> @@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
>  	evt->broadcast = smp_timer_broadcast;
>  #endif
>  
> -
> -#ifdef CONFIG_SMP
> -	evt->broadcast = smp_timer_broadcast;
> -#endif
> -
> -
>  	evt->name = "bfin_core_timer";
>  	evt->rating = 350;
>  	evt->irq = -1;
> 

Looks good to me.

Feel free to add
  Reviewed-by: Jesper Juhl <jj@...osbits.net>
if you like.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/