lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121219133107.GZ8798@dm> Date: Wed, 19 Dec 2012 13:31:07 +0000 From: Andy Whitcroft <apw@...onical.com> To: Joe Perches <joe@...ches.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Marcelo Tosatti <mtosatti@...hat.com>, Alexander Graf <agraf@...e.de>, David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH V2] checkpatch: Warn on uapi #includes that #include <uapi/... On Tue, Dec 18, 2012 at 05:30:58PM -0800, Joe Perches wrote: > Avoid specifying internal uapi #include paths with uapi/... > as userspace should not use and never see that. > > Neaten message line wrapping above. > > Signed-off-by: Joe Perches <joe@...ches.com> > cc: David Howells <dhowells@...hat.com> > --- > scripts/checkpatch.pl | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 054a293..5eab67e 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2238,8 +2238,11 @@ sub process { > my $path = $1; > if ($path =~ m{//}) { > ERROR("MALFORMED_INCLUDE", > - "malformed #include filename\n" . > - $herecurr); > + "malformed #include filename\n" . $herecurr); > + } > + if ($path =~ "^uapi/" && $realfile =~ m@\binclude/uapi/@) { > + ERROR("UAPI_INCLUDE", > + "No #include in ...include/uapi/... should use a uapi/ path prefix\n" . $herecurr); > } > } > Looks reasonable indeed. Acked-by: Andy Whitcroft <apw@...onical.com> -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists