linux-kernel - Re: [PATCH] rtc: tx4939: Kill get_tx4939rtc_plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121219.221240.129782578.anemo@mba.ocn.ne.jp>
Date:	Wed, 19 Dec 2012 22:12:40 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	axel.lin@...ics.com
Cc:	akpm@...ux-foundation.org, a.zummo@...ertech.it,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: tx4939: Kill get_tx4939rtc_plat_data() function

On Wed, 19 Dec 2012 17:29:04 +0800, Axel Lin <axel.lin@...ics.com> wrote:
> Simply use dev_get_drvdata() instead.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/rtc/rtc-tx4939.c |   21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)

Hi Axel,

Thank you for cleanup, but, a platform driver should use
platform_get_drvdata / platform_set_drvdata, no?

I think using dev_get_drvdata() in platform_get_drvdata() is an
implementation detail of the platform device framework, so we should
not depends on such an internal detail.

If there was any reason to use dev_get_drvdata, please convert all
platform_get_drvdata and platform_set_drvdata to dev_get_drvdata and
dev_set_drvdata.  We should avoid mixing two APIs.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/