linux-kernel - Re: [PATCH 1/2] ASoC: tlv320aic326x: Support for TI TLV320AIC3262 audio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Dec 2012 16:50:44 +0100
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Mehar Bajwa <mehar.bajwa@...com>
Cc:	Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	M R Swami Reddy <mr.swami.reddy@...com>,
	Rajeev Kumar <rajeev-dlh.kumar@...com>,
	amoderator list <lsa-devel@...a-project.org>,
	open list <linux-kernel@...r.kernel.org>,
	Moderator list <devicetree-discuss@...ts.ozlabs.org>,
	Hari <harik@...com>, Mehar Bajwa <mehar.bajwa@...com>,
	Mukund <navada@...com>
Subject: Re: [PATCH 1/2] ASoC: tlv320aic326x: Support for TI TLV320AIC3262 audio driver

>>>>> "Mehar" == Mehar Bajwa <mehar.bajwa@...com> writes:

Hi,

 Mehar> TI TLV320AIC3262 is a flexible, low-power, low-voltage stereo
 Mehar> audio codec with digital microphone inputs and programmable
 Mehar> outputs. It includes powertune capabilities, enhanced
 Mehar> fully-programmable miniDSP, fixed predefined and parameterizable
 Mehar> signal processing blocks, integrated PLL and flexible digital
 Mehar> interfaces.

 Mehar> +	file = devm_kzalloc(codec->dev, PAGE_SIZE, GFP_KERNEL);
 Mehar> +	if (file == NULL)
 Mehar> +		return -ENOMEM;
 Mehar> +
 Mehar> +	snprintf(file, PAGE_SIZE, "%s_fw_v%d.bin", ps_state->dev_name,
 Mehar> +				ps_state->version);
 Mehar> +	file[PAGE_SIZE - 1] = '\0';
 Mehar> +
 Mehar> +	ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_HOTPLUG,
 Mehar> +				file, codec->dev,
 Mehar> +				GFP_KERNEL, codec, aic3262_firmware_load);

What is this firmware, where can it be found and what is it's license?

You seem to be leaking file here.

 Mehar> +	if (ret < 0) {
 Mehar> +		dev_err(codec->dev, "Firmware request failed\n");
 Mehar> +		goto firm_err;
 Mehar> +	}
 Mehar> +
 Mehar> +	return 0;
 Mehar> +firm_err:
 Mehar> +	if (irq_ret)
 Mehar> +		aic3xxx_free_irq(aic3xxx,
 Mehar> +				 AIC3XXX_IRQ_HEADSET_DETECT, codec);
 Mehar> +	destroy_workqueue(aic3262->workqueue);
 Mehar> +work_err:
 Mehar> +	kfree(aic3262->cfw_p);
 Mehar> +	return ret;
 Mehar> +}

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/