linux-kernel - Re: [boot crash] Re: [GIT PULL[ block drivers bits for 3.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx71aA5_eX1=DjKG-Wd0u9YeryD6FeAk9HJ1DnxRTwPoA@mail.gmail.com>
Date:	Wed, 19 Dec 2012 08:29:25 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Shaohua Li <shli@...ionio.com>, Neil Brown <neilb@...e.de>,
	Ingo Molnar <mingo@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [boot crash] Re: [GIT PULL[ block drivers bits for 3.8

On Wed, Dec 19, 2012 at 6:47 AM, Jens Axboe <axboe@...nel.dk> wrote:
>
> It should all just be in sectors. The limits set are in bytes (could be
> sectors too, but doesn't matter so much), but any interface operates in
> sectors.
>
> I'm happy with your proposed fix. I think you should shove it in there,
> then I'll make sure we get it cleaned up for 3.9.

Ok, committed and pushed out. Neil, can you please test it on whatever
raid setting you can have?

In particular, it would be interesting to make sure it works correctly
even without LBD support on 32-bit devices on partitions that start
more than 4GB into the device, because that's the case I think was
broken before.

> Of course it's been tested. Granted it got moved over too late (as 1 of
> 2 that did), but I've run the branch on a multitude of systems.
> Apparently none of them hit the case of having a zero granularity
> reported, so never hit the bug.

I presumably happens on pretty much anything that doesn't have
discard. Of course, I've personally gotten rid of any rotating devices
I have, but it still sounds like there's a big testing hole somewhere.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/