linux-kernel - Re: [PATCH] scripts: add checkmaintainers.py

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Dec 2012 09:43:42 -0800
From:	Joe Perches <joe@...ches.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Michal Marek <mmarek@...e.cz>,
	Cesar Eduardo Barros <cesarb@...arb.net>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] scripts: add checkmaintainers.py

On Wed, 2012-12-19 at 16:07 +0100, Borislav Petkov wrote:
> On Tue, Dec 18, 2012 at 01:33:19PM -0800, Joe Perches wrote:
> > On Tue, 2012-12-18 at 21:47 +0100, Borislav Petkov wrote:
> > > Oh well, enough games for today.
> > 
> > Maybe try this tomorrow?
> 
> $ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict -
> Use of uninitialized value $herecurr in concatenation (.) or string at ./scripts/checkpatch.pl line 1333.
> CHECK: Patch renames arch/x86/Kconfig to arch/x86/Kconfig.old, update MAINTAINERS?
> 
> yes, except the warning.
> 
> $ git commit -a
> arch/x86/Kconfig.old:451: trailing whitespace.
> +         Internet Device(MID) platform.

That's the output from a:
$ git diff-index --check --cached HEAD --

> This doesn't seem to work although I have the same pre-commit hook as
> the above line: " git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict -"

perhaps you need an exec prefix

When I use this file
$ cat .git/hooks/pre-commit
exec  git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict -
$

it works fine.

Here's the latest checkpatch diff without that
concatenation warning for you to try.



View attachment "cp_boris.diff" of type "text/x-patch" (2157 bytes)