linux-kernel - Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121219204852.GH24895@liondog.tnic>
Date:	Wed, 19 Dec 2012 21:48:53 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent
 with pud/pmd

On Tue, Dec 18, 2012 at 07:37:14PM -0800, Yinghai Lu wrote:
> update to :
> 
> ---
> Subject: [PATCH] x86, mm: make pgd next calculation consistent with pud/pmd
> 
> Just like the way we calculate next for pud and pmd, aka
> round down and add size.
> 
> also remove not needed next checking, just pass end with phys_pud_init.
> 
> pyhs_pud_init() uses PTRS_PER_PUD to stop its loop early so it could handle
> big end properly.

Almost there, let's merge the last two sentences:

"Also, do not boundary-check 'next' but pass 'end' down to
phys_pud_init() instead because the loop in there terminates at
PTRS_PER_PUD and thus can handle a possibly bigger 'end' properly."

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/