lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121220003705.GA29672@core.coreip.homeip.net> Date: Wed, 19 Dec 2012 16:37:05 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Christophe TORDEUX <christophe@...deux.net> Cc: Henrik Rydberg <rydberg@...omail.se>, Tai-hwa Liang <avatar@...telic.com>, Oskari Saarenmaa <os@...u.fi>, Paul Fox <pgf@...top.org>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org Subject: Re: [PATCH 01/01] Input multitouch: fix horizontal two-finger-scrolling on Sentelic touchpads On Thu, Dec 20, 2012 at 12:09:45AM +0100, Christophe TORDEUX wrote: > From: Christophe TORDEUX <christophe@...deux.net> > > Apply the following change to the Sentelic touchpad driver: > report only the position of the first finger as absolute non-MT > coordinates, instead of reporting both fingers alternatively. Actual MT > events are unaffected. > > Signed-off-by: Christophe TORDEUX <christophe@...deux.net> > ---- > > This is a much simpler version of my patch. Basically, it makes little > sense to report both fingers alternatively, as long as it's non-MT > events. With this approach, storing coordinates of the previously > reported touch is not necessary. This patch is against kernel version > 3.7. Works with a touchpad version STL3888_C0, very probably works on > all later version, and very probably does not impact any earlier > version. This patch has two effects: > 1) fix horizontal and improve vertical scrolling, though maybe in a > coincidental way and 2) work towards making the non-MT absolute events > a purely legacy single finger fallback mode, without breaking anything. OK, this makes a lot of sense and I will be applying this; thanks! > > diff -uprN -X vanilla/linux-3.7-rc8/Documentation/dontdiff vanilla/linux-3.7/drivers/input/mouse/sentelic.c linux-3.7/drivers/input/mouse/sentelic.c > --- vanilla/linux-3.7/drivers/input/mouse/sentelic.c 2012-12-15 13:51:58.768136524 +0100 > +++ linux-3.7/drivers/input/mouse/sentelic.c 2012-12-19 23:26:49.289517251 +0100 > @@ -791,7 +791,7 @@ static psmouse_ret_t fsp_process_byte(st > fsp_set_slot(dev, 0, fgrs > 0, abs_x, abs_y); > fsp_set_slot(dev, 1, false, 0, 0); > } > - if (fgrs > 0) { > + if (fgrs ==1 || (fgrs == 2 && !(packet[0] & FSP_PB0_MFMC_FGR2))) { > input_report_abs(dev, ABS_X, abs_x); > input_report_abs(dev, ABS_Y, abs_y); > } -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists