linux-kernel - Re: [PATCH] ASoC: dapm: Fix the unpaired runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Dec 2012 13:51:05 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
Cc:	"lrg@...com" <lrg@...com>, "perex@...ex.cz" <perex@...ex.cz>,
	"tiwai@...e.de" <tiwai@...e.de>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases

On Thu, Dec 20, 2012 at 06:37:26AM +0000, Liu, Chuansheng wrote:

> Meanwhile, is it useful to add one warning there for that case?
> After all, in probing, set the bias to _STANDBY even idle_bias_off == 1, and calling get_runtime_sync(), it
> will let the code more obscure. So giving a warning there to indicate the driver:
> it is not suggested that in probing, set the bias to _STANDBY even idle_bias_off == 1.

Probably, send a patch please.  Like I say it is possible to start off
in _STANDBY providing the driver grabs the runtime PM reference too but
I can't think of any reason for doing that so the warning seems sensible.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)