linux-kernel - Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50D340E1.7040600@wwwdotorg.org>
Date:	Thu, 20 Dec 2012 09:46:25 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Laxman Dewangan <ldewangan@...dia.com>,
	"vinod.koul@...el.com" <vinod.koul@...el.com>
CC:	"djbw@...com" <djbw@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] dma: tegra: implement flags parameters for cyclic transfer

On 12/19/2012 11:11 PM, Laxman Dewangan wrote:
> On Wednesday 19 December 2012 10:32 PM, Stephen Warren wrote:
>> On 12/19/2012 06:40 AM, Laxman Dewangan wrote:
>>> The flag parameter is added in the cyclic transfer request.
>>> Use the flag option of:
>>> - DMA_PREP_INTERRUPT for enabling interrupt.
>>> - DMA_CTRL_ACK for deciding whether ack is requred or not for
>>>    descriptor.
>> Do the relevant drivers that use Tegra's DMA engine already set flags
>> correctly, so that this change won't cause any regressions?
>>
> 
> Currently, the sound soc driver uses the cyclic mode of dma transfer and
> it has already enable the proper flags. This was done recently after
> adding flags in cyclic api.
> Also, there was bug in our dma driver for not setting DMA_CTRL_ACK by
> default for cyclic case.
> This will fix the issue.

OK. I assume "This was done recently after adding flags in cyclic api."
was a patch that went into 3.8?  So, this patch is a bug-fix that should
be included in 3.8 then?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/