linux-kernel - [tip:x86/urgent] x86, efi: correct precedence of operators in setup_efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-886d751a2ea99a160f2d0a472231566d9cb0cf58@git.kernel.org>
Date:	Thu, 20 Dec 2012 11:59:21 -0800
From:	tip-bot for Sasha Levin <sasha.levin@...cle.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	mjg@...hat.com, linux-kernel@...r.kernel.org,
	sasha.levin@...cle.com, hpa@...or.com, mingo@...nel.org,
	seth.forshee@...onical.com, matt.fleming@...el.com,
	bhelgaas@...gle.com, tglx@...utronix.de, hpa@...ux.intel.com
Subject: [tip:x86/urgent] x86, efi:
  correct precedence of operators in setup_efi_pci

Commit-ID:  886d751a2ea99a160f2d0a472231566d9cb0cf58
Gitweb:     http://git.kernel.org/tip/886d751a2ea99a160f2d0a472231566d9cb0cf58
Author:     Sasha Levin <sasha.levin@...cle.com>
AuthorDate: Thu, 20 Dec 2012 14:11:33 -0500
Committer:  H. Peter Anvin <hpa@...ux.intel.com>
CommitDate: Thu, 20 Dec 2012 11:47:14 -0800

x86, efi: correct precedence of operators in setup_efi_pci

With the current code, the condition in the if() doesn't make much sense due to
precedence of operators.

Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
Link: http://lkml.kernel.org/r/1356030701-16284-25-git-send-email-sasha.levin@oracle.com
Cc: Matt Fleming <matt.fleming@...el.com>
Cc: Matthew Garrett <mjg@...hat.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Seth Forshee <seth.forshee@...onical.com>
Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
---
 arch/x86/boot/compressed/eboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index b1942e2..18e329c 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
 		if (status != EFI_SUCCESS)
 			continue;
 
-		if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
+		if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
 			continue;
 
 		if (!pci->romimage || !pci->romsize)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/