linux-kernel - Re: [PATCH] tools/usb: remove unneeded 'continue' and simplify condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121220203242.GC28433@arwen.pp.htv.fi>
Date:	Thu, 20 Dec 2012 22:32:43 +0200
From:	Felipe Balbi <balbi@...com>
To:	Sasha Levin <sasha.levin@...cle.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Du Changbin <changbinx.du@...el.com>,
	Michal Nazarewicz <mina86@...a86.com>,
	Felipe Balbi <balbi@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools/usb: remove unneeded 'continue' and simplify
 condition

On Thu, Dec 20, 2012 at 02:11:15PM -0500, Sasha Levin wrote:
> Basically remove unneeded code. Since that 'continue' is at the end
> of the for() there's no need for it.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Acked-by: Felipe Balbi <balbi@...com>

> ---
>  tools/usb/testusb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> index 68d0734..643cd77 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
> @@ -507,10 +507,8 @@ usage:
>  			return handle_testdev (entry) != entry;
>  		}
>  		status = pthread_create (&entry->thread, 0, handle_testdev, entry);
> -		if (status) {
> +		if (status)
>  			perror ("pthread_create");
> -			continue;
> -		}
>  	}
>  	if (device) {
>  		struct testdev		dev;
> -- 
> 1.8.0
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)