linux-kernel - Re: [PATCH] mm/sparse: don't check return value of alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Dec 2012 12:43:52 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Sasha Levin <sasha.levin@...cle.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...e.cz>,
	Gavin Shan <shangw@...ux.vnet.ibm.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/sparse: don't check return value of alloc_bootmem
 calls

On Thu, 20 Dec 2012, Sasha Levin wrote:

> So what we really need is to update the documentation of __alloc_bootmem_node, I'll send
> a patch that does that instead.
> 

It panics iff slab is not available to allocate from yet, otherwise it's 
just a wrapper around kmalloc().  This emits a warning to the kernel log, 
though, so __alloc_bootmem_node() should certainly not be called that late 
in the boot sequence.

Since __alloc_bootmem_node_nopanic() is the way to avoid the panic, I 
think the change that should be made here so to panic even when the 
kmalloc() fails in __alloc_bootmem_node(), __alloc_bootmem_node_high(), 
and __alloc_bootmem_low_node().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/