lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121220205113.GD14363@n2100.arm.linux.org.uk> Date: Thu, 20 Dec 2012 20:51:13 +0000 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Lee Jones <lee.jones@...aro.org> Cc: Linus Walleij <linus.walleij@...aro.org>, Steve Glendinning <steve.glendinning@...well.net>, Robert Marklund <robert.marklund@...ricsson.com>, linus.walleij@...ricsson.com, arnd@...db.de, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality On Thu, Dec 20, 2012 at 08:35:14PM +0000, Lee Jones wrote: > On Thu, 20 Dec 2012, Russell King - ARM Linux wrote: > > > On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > > > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones <lee.jones@...aro.org> wrote: > > > > > > > Some platforms provide clocks which require enabling before the > > > > SMSC911x chip will power on. This patch uses the new common clk > > > > framework to do just that. If no clock is provided, it will just > > > > be ignored and the driver will continue to assume that no clock > > > > is required for the chip to run successfully. > > > > > > > > Cc: Steve Glendinning <steve.glendinning@...well.net> > > > > Cc: netdev@...r.kernel.org > > > > Signed-off-by: Lee Jones <lee.jones@...aro.org> > > > > > > Seems to me like it'll do the trick. > > > Acked-by: Linus Walleij <linus.walleij@...aro.org> > > > > This looks fairly dangerous. What about those platforms which use this > > driver, but don't provide a clock for it? > > > > It looks like this will result in those platforms losing their ethernet > > support. There's at least a bunch of the ARM evaluation boards which > > make use of this driver... > > Right, but nothing should regress. If no clock is provided the driver > moves on during the request and will refuse to prepare, enable and > disable there after. > > Unless I've made a mistake somewhere? If so, I'd be happy to fixup. No, but... don't use NULL for that. Use IS_ERR(pdata->clk) instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists