linux-kernel - Re: [PATCH] rcutorture: don't compare ptr with 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121220223912.GA12614@leaf>
Date:	Thu, 20 Dec 2012 14:39:12 -0800
From:	Josh Triplett <josh@...edesktop.org>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcutorture: don't compare ptr with 0

On Thu, Dec 20, 2012 at 02:11:28PM -0500, Sasha Levin wrote:
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Fair enough.  You might as well change the first half of the conditional
too, though.  In any case:

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  kernel/rcutorture.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index 31dea01..0249800 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -1749,7 +1749,7 @@ static int rcu_torture_barrier_init(void)
>  	barrier_cbs_wq =
>  		kzalloc(n_barrier_cbs * sizeof(barrier_cbs_wq[0]),
>  			GFP_KERNEL);
> -	if (barrier_cbs_tasks == NULL || barrier_cbs_wq == 0)
> +	if (barrier_cbs_tasks == NULL || !barrier_cbs_wq)
>  		return -ENOMEM;
>  	for (i = 0; i < n_barrier_cbs; i++) {
>  		init_waitqueue_head(&barrier_cbs_wq[i]);
> -- 
> 1.8.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/