linux-kernel - Re: [RFC PATCH 4/4] ext4: Fix an incorrect comment about i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121220234249.GA13474@quack.suse.cz>
Date:	Fri, 21 Dec 2012 00:42:49 +0100
From:	Jan Kara <jack@...e.cz>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	linux-kernel@...r.kernel.org,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>,
	Dave Chinner <david@...morbit.com>,
	Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>
Subject: Re: [RFC PATCH 4/4] ext4: Fix an incorrect comment about i_mutex

On Thu 20-12-12 15:10:12, Andy Lutomirski wrote:
> Signed-off-by: Andy Lutomirski <luto@...capital.net>
  The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@...e.cz>

  BTW: The right person for this patch is ext4 maintainer:
"Theodore Ts'o" <tytso@....edu>
  Since this is completely independent of anything else in this series,
just submit the patch to him. Thanks!

								Honza
> ---
>  fs/ext4/fsync.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
> index be1d89f..8c15642 100644
> --- a/fs/ext4/fsync.c
> +++ b/fs/ext4/fsync.c
> @@ -113,8 +113,6 @@ static int __sync_inode(struct inode *inode, int datasync)
>   *
>   * What we do is just kick off a commit and wait on it.  This will snapshot the
>   * inode to disk.
> - *
> - * i_mutex lock is held when entering and exiting this function
>   */
>  
>  int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> -- 
> 1.7.11.7
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/