linux-kernel - RE: [PATCH v4 09/11] x86/head64.c: Early update ucode in 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3E5A0FA7E9CA944F9D5414FEC6C7122047109A03@ORSMSX105.amr.corp.intel.com>
Date:	Fri, 21 Dec 2012 05:07:02 +0000
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	H Peter Anvin <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Mallick, Asit K" <asit.k.mallick@...el.com>,
	Tigran Aivazian <tigran@...azian.fsnet.co.uk>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Borislav Petkov <borislav.petkov@....com>,
	linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: RE: [PATCH v4 09/11] x86/head64.c: Early update ucode in 64-bit

> > From: yhlu.kernel@...il.com [mailto:yhlu.kernel@...il.com] On Behalf
> Of
> > Yinghai Lu
> > On Thu, Dec 20, 2012 at 11:48 AM, Fenghua Yu <fenghua.yu@...el.com>
> > wrote:
> > > From: Fenghua Yu <fenghua.yu@...el.com>
> > >
> > > This updates ucode on BSP in 64-bit mode. Paging and virtual
> address
> > are
> > > working now.
> > >
> > > Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> > > ---
> > >  arch/x86/kernel/head64.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> > > index e1cb611..1ccbaf1 100644
> > > --- a/arch/x86/kernel/head64.c
> > > +++ b/arch/x86/kernel/head64.c
> > > @@ -26,6 +26,7 @@
> > >  #include <asm/kdebug.h>
> > >  #include <asm/e820.h>
> > >  #include <asm/bios_ebda.h>
> > > +#include <asm/microcode.h>
> > >
> > >  /*
> > >   * Manage page tables very early on.
> > > @@ -179,6 +180,11 @@ void __init x86_64_start_kernel(char *
> > real_mode_data)
> > >         }
> > >         load_idt((const struct desc_ptr *)&idt_descr);
> > >
> > > +       /*
> > > +        * Load microcode early on BSP.
> > > +        */
> > > +       load_ucode_bsp(__va(real_mode_data));
> > > +
> > >         copy_bootdata(__va(real_mode_data));
> >
> > can you make load_ucode_bsp take boot_param directly instead of
> > real_mode_data. ?
> >
> > could be
> >
> >
> >         copy_bootdata(__va(real_mode_data));
> > +
> > +        /* Load microcode early on BSP. */
> > +       load_ucode_bsp(&boot_params);
> > +
> >
> > because copy_bootdata, already copy boot_params...
> >
> > Thanks
> >
> > Yinghai
> 
> That's right. Will fix this.

I'll call load_ucode_bsp(void) though which will access the global boot_params variable.

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/