linux-kernel - Re: [PATCH] sched/rt: Move cpu rq properties from "struct rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <545781356071709@web16g.yandex.ru>
Date:	Fri, 21 Dec 2012 10:35:09 +0400
From:	Kirill Tkhai <tkhai@...dex.ru>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-rt-users <linux-rt-users@...r.kernel.org>
Subject: Re: [PATCH] sched/rt: Move cpu rq properties from "struct rt_rq" to "struct rq"



21.12.2012, 03:07, "Steven Rostedt" <rostedt@...dmis.org>:
> On Fri, 2012-12-21 at 02:16 +0400, Kirill Tkhai wrote:
>
>>  20.12.2012, 21:53, "Thomas Gleixner" <tglx@...utronix.de>:
>>>  On Tue, 18 Dec 2012, Kirill Tkhai wrote:
>>>>   The members rt_nr_total, rt_nr_migratory, overloaded and pushable_tasks are
>>>>   properties of cpu runqueue, not group rt_rq.
>>>  Why?
>>  Because, they depend on number and properties of all processes of rq, not of nested rt_rq.
>
> You're answer is still confusing.
>
>         struct rq {
>                 [...]
>                 struct rt_rq rt;
>
> rt_rq is just a part of rq. What's the point?
>
>         rq = container_of(rt_rq, struct rt_rq, rt);
>
> As the comment above struct rt_rq says:
>
> /* Real-Time classes' related field in a runqueue: */
>
> Those look like fields related to the Real-Time class. I don't see them
> used outside of kernel/sched/rt.c
>
                                    
           entity_1->my_q_1
           /                        
          /                         
rq->rt  -entity_2->my_q_2
          \                          
           \                           
             entity_n->my_q_n
                                        

I say about child rt_rqs (my_q_1....my_q_n). They don't have rt_nr_total, rt_nr_migratory, overloaded and pushable_tasks.
The only use of overloaded, for example, is "rq->rt.overloaded". The same with other variables.

Kirill


> -- Steve
>
>>>  Thanks,
>>>
>>>          tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/