linux-kernel - Re: 3.8 NFS build breakage with !CONFIG_NFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121221083305.GB15226@liondog.tnic>
Date:	Fri, 21 Dec 2012 09:33:05 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
Cc:	David Howells <dhowells@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 3.8 NFS build breakage with !CONFIG_NFS_FSCACHE

On Fri, Dec 21, 2012 at 11:14:21AM +0530, Vineet Gupta wrote:
> Hi David,
> 
> Not sure if this was report/fixed already - but as of today's Linus tree
> (tip has commit 96680d2), I'm seeing a build breakage due to a trivial
> missing def for nfs_fscache_wait_on_invalidate.
> 
> Following fixes it for me.
> 
> diff --git a/fs/nfs/fscache.h b/fs/nfs/fscache.h
> index 277b027..4ecb766 100644
> --- a/fs/nfs/fscache.h
> +++ b/fs/nfs/fscache.h
> @@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct
> inode *inode,
>  
>  
>  static inline void nfs_fscache_invalidate(struct inode *inode) {}
> +static inline void nfs_fscache_wait_on_invalidate(struct inode *inode) {}

I see the same thing here. Please write a proper patch and quote the
build error in the commit message:

fs/nfs/inode.c: In function ‘nfs_invalidate_mapping’:
fs/nfs/inode.c:887:2: error: implicit declaration of function ‘nfs_fscache_wait_on_invalidate’ [-Werror=implicit-function-declaration]

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/