linux-kernel - Re: [PATCH] tools lib traceevent: remove redundant check from process_dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121221125839.GB2973@danjae>
Date:	Fri, 21 Dec 2012 21:58:39 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools lib traceevent: remove redundant check from
 process_dynamic_array

On Thu, Dec 20, 2012 at 02:11:13PM -0500, Sasha Levin wrote:
> We check twice that 'field' is non-NULL, no need to do that.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>  tools/lib/traceevent/event-parse.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index 5a824e3..f7dc053 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -2481,11 +2481,6 @@ process_dynamic_array(struct event_format *event, struct print_arg *arg, char **
>  
>  	free_token(token);
>  	arg = alloc_arg();
> -	if (!field) {

I think it should be 'if (!arg)' instead.

Thanks,
Namhyung


> -		do_warning("%s: not enough memory!", __func__);
> -		*tok = NULL;
> -		return EVENT_ERROR;
> -	}
>  
>  	type = process_arg(event, arg, &token);
>  	if (type == EVENT_ERROR)
> -- 
> 1.8.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/