linux-kernel - RE: [PATCH v2 1/4] ODROID-X: dts: Add board dts file for ODROID-X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <007b01cddfa6$f158b460$d40a1d20$@samsung.com>
Date:	Fri, 21 Dec 2012 10:13:50 -0800
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Dongjin Kim' <tobetter@...il.com>
Cc:	'Russell King' <linux@....linux.org.uk>,
	'Olof Johansson' <olof@...om.net>,
	'Jason Cooper' <jason@...edaemon.net>,
	'Shawn Guo' <shawn.guo@...aro.org>,
	'Andrew Lunn' <andrew@...n.ch>,
	'Jean-Christophe PLAGNIOL-VILLARD' <plagnioj@...osoft.com>,
	'Thomas Abraham' <thomas.abraham@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH v2 1/4] ODROID-X: dts: Add board dts file for ODROID-X

Dongjin Kim wrote:
> 
> Add initial dtb file for Hardkernel's ODROID-X board based on EXYNOS4412
> SoC.
> 
> Signed-off-by: Dongjin Kim <tobetter@...il.com>
> ---
>  arch/arm/boot/dts/Makefile               |    1 +
>  arch/arm/boot/dts/exynos4412-odroidx.dts |   47
> ++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-odroidx.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d077ef8..364d67b 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-
> origen.dtb \
>  	exynos4210-trats.dtb \
>  	exynos5250-smdk5250.dtb \
>  	exynos5440-ssdk5440.dtb \
> +	exynos4412-odroidx.dtb \
>  	exynos4412-smdk4412.dtb \
>  	exynos5250-smdk5250.dtb \
>  	exynos5250-snow.dtb

Just now, I sorted out the ordering alphabetically and submitted.

> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts
> b/arch/arm/boot/dts/exynos4412-odroidx.dts
> new file mode 100644
> index 0000000..323ed177
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> @@ -0,0 +1,47 @@
> +/*
> + * Hardkernel's Exynos4412 based ODROID-X board device tree source
> + *
> + * Copyright (c) 2012 Dongjin Kim <tobetter@...il.com>
> + *
> + * Device tree source file for Hardkernel's ODROID-X board which is based
> on
> + * Samsung's Exynos4412 SoC.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +/include/ "exynos4412.dtsi"
> +
> +/ {
> +	model = "Hardkernel ODROID-X board based on Exynos4412";
> +	compatible = "hardkernel,exynos4412", "samsung,exynos4412";

Probably, 

+	compatible = "hardkernel,odroid-x", "samsung,exynos4412";

> +
> +	memory {
> +		reg = <0x40000000 0x40000000>;

If you can't see any error message in kernel boot, boot-loader should inform
the memory size and bank information to the kernel. So should be separated
with bank size, 256MiB. But I need to think again as Olof said in other
thread.

> +	};
> +
> +	serial@...00000 {
> +		status = "okay";
> +	};
> +
> +	serial@...10000 {
> +		status = "okay";
> +	};
> +
> +	serial@...20000 {
> +		status = "okay";
> +	};
> +
> +	serial@...30000 {
> +		status = "okay";
> +	};
> +
> +	sdhci@...30000 {
> +		bus-width = <4>;
> +		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
> +		pinctrl-names = "default";
> +		status = "okay";
> +	};
> +};
> --
> 1.7.9.5

BTW, you don't need any bootargs as default?

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/