Message-ID: <AC1B83CE65082B4DBDDB681ED2F6B2EF023202C5@EXHQ.corp.stratus.com>
Date:	Fri, 21 Dec 2012 16:38:15 -0500
From:	"Evans, Robert" <Robert.Evans@...atus.com>
To:	<minyard@....org>
Cc:	"Grant Likely" <grant.likely@...retlab.ca>,
	"Rob Herring" <rob.herring@...xeda.com>,
	<openipmi-developer@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>,
	"Tony Camuso" <tcamuso@...hat.com>, <jparadis@...hat.com>,
	"Evans, Robert" <Robert.Evans@...atus.com>
Subject: RE: [PATCH] ipmi: add new kernel options to prevent automatic ipmi init

I have made a few observations in the past few days:

1) Unique IPMI device ID's did not seem to make a difference.
Stratus still could not hot remove one of the KCS interfaces.


2) From what I see in IPMI spec section 20.1, having unique
device ID's is not required:

   Controllers that implement identical sets of applications
   commands can have the same Device ID in a given system.
   Thus, a 'standardized' controller could be produced where
   multiple instances of the controller are used in a system,
   and all have the same Device ID value.  [The controllers
   would still be differentiable by their address, location,
   and associated information for the controllers in the
   Sensor Data Records.]


3) Stratus can get by without a change to kernel 2.6.32

Stratus could not hot-remove all interfaces automatically
discovered by ipmi_si, but it is possible to hot-remove all
hardcoded interfaces.  One of the Stratus KCS interfaces will
always be online at boot time.  Thus if Stratus hardcodes both
of the KCS interfaces, at least one of those will be detected
when ipmi_si initializes; this will prevent ipmi_si from trying
to auto-detect any interfaces.  Later during system startup,
a Stratus script can run to hot-remove all interfaces from use
by ipmi_si.  Using this technique Stratus has a method to
dedicate all the KCS interfaces exclusively for use by the
Stratus driver without needing any kernel changes.

I have verified this technique with the most recent 2.6.32-348
kernel released in a Red Hat Enterprise Linux 6.4 beta snapshot.
As long as the same behavior is present in the upstream kernel,
we do not need a change to the kernel to support Stratus servers.


On 12/17/2012 4:14 PM, Evans, Robert wrote:
>On 12/14/2012 12:02 PM, Corey Minyard wrote:
>>On 12/14/2012 10:25 AM, Evans, Robert wrote:
>>> Corey,
>>>
>>> Thanks for the thoughtful reply.  Below I respond in detail to
>>> these three points.
>>>
>>> 1) Why building a variant kernel with ipmi_si as a module is not
>>>     feasible.
>>>
>>> 2) User mode access to IPMI on Stratus systems (e.g. ipmitool).
>>>
>>> 3) ipmi_si hot removal seems to not work as needed.
>>>
>>> Stratus might be able to use the hot removal option instead of the
>>> proposed patch if hot removal can remove all interfaces from usage
>>> by ipmi_si.  Our testing of this option was not successful as
>>> shown below.
>>>
>>>   - - -
>>>
>>> 1) Why building a variant kernel with ipmi_si as a module is not
>>> feasible:
>>>
>>> Stratus sells servers based upon Red Hat Enterprise Linux (RHEL).
>>> In the next release of RHEL, ipmi_si will be built into the kernel
>>> so that access to ACPI opregion is available early in kernel
>>> startup.  Stratus systems run the Red Hat kernel so that the
>>> system is certified and supported by Red Hat.  For this reason
>>> using a custom kernel configured to build ipmi_si as a module is
>>> not an option.
>>
>>Yes, the RHEL engineer explained this to me, and it makes sense now.
Thanks.
>>
>>>
>>>
>>> 2) User mode access to IPMI on Stratus systems:
>>>
>>> Although Stratus provides a replacement for ipmi_si, we depend
>>> on ipmi_msghandler and ipmi_devintf.  The device /dev/ipmi0 is
>>> present and this device is utilized by the user-mode system
>>> management software Stratus supplies.
>>>
>>> Therefore other programs like ipmitool can send IPMI commands and
>>> get responses on Stratus systems.
>>
>>Ah, ok. That's good.
>>
>>>
>>>
>>>
>>> 3) Hot removal of the KCS interfaces discovered by ipmi_si seems
>>> to not do enough... One KCS cannot successfully be removed:
>>>
>>> Based upon your suggestion, we tried to use hot removal.  With
>>> RHEL 6.4 Beta (kernel-2.6.32-343.el6), Stratus attempted to hot
>>> remove the IPMI interfaces.  This was booted with
>>>   "ipmi_si.trydefaults=0"
>>> although we expect that kernel option to have no effect since a
>>> BMC is found before the defaults would be tried.
>>>
>>> This is logged when ipmi_si initializes indicating that both BMCs
>>> were discovered:
>>>
>>> ipmi message handler version 39.2
>>> IPMI System Interface driver.
>>> ipmi_si: Trying ACPI-specified kcs state machine at i/o address
0xca2,
>>> slave address 0x0, irq 0
>>> ipmi: Found new BMC (man_id: 0x000077,  prod_id: 0x05c6, dev_id:
0x41)
>>> IPMI kcs interface initialized
>>> ipmi_si: Adding SMBIOS-specified kcs state machine
>>> ipmi_si: Trying SMBIOS-specified kcs state machine at i/o address
0xda2,
>>> slave address 0x20, irq 0
>>> ipmi: interfacing existing BMC (man_id: 0x000077, prod_id: 0x05c6,
>>> dev_id: 0x41)
>>> IPMI kcs interface initialized
>>>
>>> Although there are two different BMCs, because it says
>>>   "interfacing existing BMC"
>>> it appears that ipmi_si assumes they are the same BMC.
>>
>>That's happening in the message handler and it happens because the
>>manufacturer, product, and device id all match. From the spec:
>>
>>    The Device ID is typically used in combination with the Product ID
>>    field such
>>    that the Device IDs for different controllers are unique under a
>>    given Product
>>    ID. A controller can optionally use the Device ID as an 'instance'
>>    identifier if
>>    more than one controller of that kind is used in the system.
>>    (Section 20.1)
>>
>>Different controllers in the same system are supposed to have
different 
>>device
>>IDs.
>
>I have a made an inquiry to Stratus Hardware Engineering asking why our
>product is not compliant with the specification.  I will pursue a
change
>to future products to comply.  However, Stratus has several generations
>of systems in the field for which this change will be very difficult.
>
>
>>
>>> Also, I notice the slave address for the first KCS (port CA2) seems
>>> wrong.  Maybe these findings are relevant to what happens next.
>>
>>Probably not relevant. It's not correct because, for some bizarre
>>reason, the slave address is not present in the ACPI information.
>>The slave address is only used by the message handler for the
>>IPMB return address on messages routed over IPMB.
>>
>>It is odd that one interface is specified in ACPI and the other in
DMI.
>>You can specify all of them in both tables.
>
>The Stratus server is actually two complete servers that operate in
>lockstep to provide reliable operation regardless of any single failed
>component.  One of the two I/O subsystems is active during BIOS POST.
>Only information about the active subsystem is placed in the SMBIOS
>data structure.  Thus dmidecode shows this info for either port CA2
>or DA2 depending upon which I/O CRU was active:
>
>  Handle 0x0048, DMI type 38, 18 bytes
>  IPMI Device Information
>	Interface Type: KCS (Keyboard Control Style)
>	Specification Version: 2.0
>	I2C Slave Address: 0x10
>	NV Storage Device: Not Present
>	Base Address: 0x0000000000000DA2 (I/O)
>	Register Spacing: Successive Byte Boundaries
>	Interrupt Polarity: Active High
>	Interrupt Trigger Mode: Edge
>
>I believe the ACPI data provides information to locate both KCS
interfaces.
>Therefore only one interface is found at first when ipmi_si calls
>dmi_find_bmc().  And the other interface is discovered by
acpi_find_bmc()
>or by ipmi_pnp_probe().
>
>>>
>>> After ipmi_si has been initialized, a script runs to load ftmod, the
>>> module that contains the Stratus IPMI driver.  This code was added
to
>>> hot remove the interfaces discovered by ipmi_si before loading
ftmod:
>>>
>>> for i in $(cd /proc/ipmi; ls)
>>> do
>>>      dev="IPMI${i}"
>>>      params="$(cat /proc/ipmi/${i}/params)"
>>>      msg="Considering removal of dev: ${dev} ${params}"
>>>      logger -p kern.info -t `basename ${0}` "${msg}"
>>>      echo "${msg}" > /dev/console
>>>      [ -n "${params}" ] &&
>>> 	echo "remove,`cat /proc/ipmi/${i}/params`" \
>>> 		> /sys/module/ipmi_si/parameters/hotmod
>>> done
>>>
>>> In the console log we can see this script run prior to loading the
>>> Stratus ftmod.ko and we also see that ftmod exposes a BMC:
>>>
>>> Considering removal of dev: IPMI0
>>> kcs,i/o,0xca2,rsp=1,rsi=1,rsh=0,irq=0,ipmb=0
>>> Considering removal of dev: IPMI1
>>> kcs,i/o,0xda2,rsp=1,rsi=1,rsh=0,irq=0,ipmb=32
>>> ftmod: module license 'LGPL' taints kernel.
>>> Disabling lock debugging due to kernel taint
>>> FTMOD version lsb-ft-ftmod-9.0.4-209
>>> ftmod: GLOBAL_SIZE=4194304
>>> ftmod: global_cc_memory 0xffff880037400000
>>> ipmi: Found new BMC (man_id: 0x000000,  prod_id: 0x0000, dev_id:
0x00)
>>> ipmi device interface
>>>
>>> The KCS at port DA2 is removed from use by ipmi_si.  However, the
>>> other KCS is still in use by ipmi_si.  Like ipmi_si, the Stratus
IPMI
>>> driver uses ipmi_msghandler.  With two interfaces sending commands
to
>>> the same BMC, responses seem to be misdirected.  The Stratus
management
>>> software cannot successfully commnicate with that BMC and many
errors
>>> like this are logged by ipmi_msghandler:
>>>
>>> IPMI message handler: BMC returned incorrect response, expected
netfn 3d
>>> cmd 75, got netfn 3d cmd 71
>>> IPMI message handler: BMC returned incorrect response, expected
netfn 3d
>>> cmd 71, got netfn 19 cmd 20
>>> IPMI message handler: BMC returned incorrect response, expected
netfn b
>>> cmd 40, got netfn 3d cmd 71
>>> IPMI message handler: BMC returned incorrect response, expected
netfn 3d
>>> cmd 71, got netfn d cmd 2
>>>
>>> I tried a few variations on the remove string, but never got ipmi_si
>>> to stop using the KCS at port CA2.
>>
>>When you remove it, does it disappear from /proc/ipmi? That directory
>>should be empty after running your script.
>
>After my script runs, the kernel still has one device (0) with with
>the proc files from ipmi_si and from ipmi_msghandler.  I see those
files
>exist after my script runs, but before the Stratus driver gets loaded.
>
>After it is loaded, the Stratus driver is using device (1).  For that
>device, I only see the proc files exposed by ipmi_msghandler:
>
>  # ls /proc/ipmi/?
>  /proc/ipmi/0:
>  ipmb  params  si_stats  stats  type  version
>
>  /proc/ipmi/1:
>  ipmb  stats  version
>
>I still am experimenting with this as I am curious about why the hot-
>remove is not working.
>
>
>>
>>The other strange thing is that, if the other driver is running, the
>>request_region() call in your driver should fail.
>
>The Stratus common low-level machine control code is shared by a
>few different operating systems.  I do not have a list of all the
>I/O ports the common code accesses.  So there is no request for a
>I/O port region when the Stratus common code starts.  The linux-
>specific wrapper around common code simply does in or out
>instructions to access the requested ports.
>
>
>>
>>Perhaps the first driver is leaving the device in a strange state that
is
>>confusing your driver? That doesn't seem possible. Or maybe there
>>is something in the message handler that is getting messed up? There
>>was a bug in the driver at one point that caused errors like that
>>intermittently, but not all the time.
>
>I think this is unlikely as the Stratus driver does retries and even
>can use a GPIO to reboot the BMC when communications fail.
>
>
>>
>>After sleeping on it a bit, though, I think the patch is a good idea,
and
>>I'll also add something for openfirmware and PCI. I was hoping to get
>>you a quicker solution, though, than having to deal with a patch.
>>
>>-corey
>
>I appreciate your help and would like the patch as it seems the best
>solution for existing systems.  Thanks again for your assistance.
>
>
>- Robert N. Evans
>

- Robert N. Evans


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists