[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALCETrX423Au=Q0SgdpFp7hcVBAw0t4FprO18Wk9j0K=j8fg_w@mail.gmail.com>
Date: Sat, 22 Dec 2012 00:43:30 -0800
From: Andy Lutomirski <luto@...capital.net>
To: Christoph Hellwig <hch@...radead.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Linux FS Devel <linux-fsdevel@...r.kernel.org>,
Dave Chinner <david@...morbit.com>, Jan Kara <jack@...e.cz>,
Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v2 2/3] mm: Update file times when inodes are written
after mmaped writes
On Sat, Dec 22, 2012 at 12:29 AM, Christoph Hellwig <hch@...radead.org> wrote:
> NAK, we went through great trouble to get rid of the nasty layering
> violation where the VM called file_update_time directly just a short
> while ago, reintroducing that is a massive step back.
>
> Make sure whatever "solution" for your problem you come up with keeps
> the file update in the filesystem or generic helpers.
>
There's an inode operation ->update_time that is called (if it exists)
in these patches to update the time. Is that insufficient? I could
add a new inode operation ->modified_by_mmap that would be called in
mapping_flush_cmtime if that would be better.
The original version of this patch did the update in ->writepage and
->writepages, but that may have had lock ordering issues. (I wasn't
able to confirm that there was any actual problem.)
--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists