linux-kernel - Re: [PATCH 08/25] thinkpad_acpi: don't use [delayed_]work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121222235504.GA12747@khazad-dum.debian.net>
Date:	Sat, 22 Dec 2012 21:55:04 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 08/25] thinkpad_acpi: don't use [delayed_]work_pending()

On Fri, 21 Dec 2012, Tejun Heo wrote:
> There's no need to test whether a (delayed) work item in pending
> before queueing, flushing or cancelling it.  Most uses are unnecessary
> and quite a few of them are buggy.
> 
> Remove unnecessary pending tests from thinkpad_acpi.  Only compile
> tested.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Henrique de Moraes Holschuh <ibm-acpi@....eng.br>
> Cc: ibm-acpi-devel@...ts.sourceforge.net
> Cc: platform-driver-x86@...r.kernel.org

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

> ---
> Please let me know how this patch should be routed.  I can take it
> through the workqueue tree if necessary.

It will not clash with anything I know of, so feel free to route it
through the workqueue tree.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/