linux-kernel - Re: [2.6.32.y, 2.6.34.y] Re: [PATCH] x86: Don't use the EFI reboot method by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1356297096.21837.27.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 23 Dec 2012 21:11:36 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Willy Tarreau <w@....eu>
Cc:	Jonathan Nieder <jrnieder@...il.com>, stable@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>, x86@...nel.org,
	hpa@...or.com, linux-kernel@...r.kernel.org,
	Keith Ward <keith@...os-realm.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [2.6.32.y, 2.6.34.y] Re: [PATCH] x86: Don't use the EFI reboot
 method by default

On Sun, 2012-12-23 at 22:03 +0100, Willy Tarreau wrote:
> Hi Jonathan,
> 
> [ccing Paul for 2.6.34]
> 
> On Sun, Dec 23, 2012 at 12:59:50PM -0800, Jonathan Nieder wrote:
> > Hi Willy et al,
> > 
> > Please consider
> > 
> >   f70e957cda22 x86: Don't use the EFI reboot method by default,
> >                2011-07-06
> > 
> > for application to the 2.6.32.y and 2.6.34.y trees.  The patch was
> > applied upstream late in the 3.0 cycle, so newer kernels don't need
> > it.
> > 
> > In 2011, Keith Ward wrote[1]:
> > 
> > > When attempting to reboot my my UEFI enabled system, the system hangs when
> > > calling reboot requiring me to manually reset the system via the reset switch.
> > >
> > > Screenshot: http://twitgoo.com/29bq1c
> > 
> > Ben Hutchings writes[1]:
> > 
> > > Version: 3.0.0-1
> > >
> > > I also had this problem on my own system, but it is fixed now.
> > > I bisected the fix to:
> > >
> > > commit f70e957cda22d309c769805cbb932407a5232219
> > > Author: Matthew Garrett <mjg@...hat.com>
> > > Date:   Wed Jul 6 16:52:37 2011 -0400
> > >
> > >     x86: Don't use the EFI reboot method by default
> > >
> > > which is basically equivalent to the workaround!
> > >
> > > I'll also apply this fix to squeeze as it's so simple.
> > 
> > Keith Ward also wrote[1]:
> > 
> > > It seems as if this has recently been reported at Ubuntu's Launchpad as well:
> > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/721576
> > 
> > There are a variety of reports of the same panic at that bug on
> > 2.6.32.y-, 2.6.38.y-, and 2.6.39-based kernels.  Passing "reboot=a,w"
> > on the kernel command line avoids trouble for reporters.
> > 
> > Regards,
> > Jonathan
> > 
> > [1] http://bugs.debian.org/626022
> 
> Thanks for the detailed report. I'm queuing it now.

In 2.6.32 the relevant code is in arch/x86/kernel/efi.c.  With the
filename changed, the patch applies cleanly and works for me.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of them.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)