linux-kernel - Re: [Regression w/ patch] Media commit causes user space to misbahave (was: Re: Linux 3.8-rc1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Dec 2012 14:29:04 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Hans Verkuil <hans.verkuil@...co.com>
Subject: Re: [Regression w/ patch] Media commit causes user space to misbahave
 (was: Re: Linux 3.8-rc1)

On Sun, Dec 23, 2012 at 12:21 PM, Mauro Carvalho Chehab
<mchehab@...hat.com> wrote:
>
> Agreed: ENOENT was a bad choice, and it should be reverted.

Well, *any* other error value is likely a bad choice.

> What I'm trying to understand is why pulseaudio is complaining.
> Is it because it only accepts EINVAL error code for media controls?

What I am trying to understand is why you even care, and how you could
*possibly* ever even consider this to be a user-space bug.

Applications *do* care about error return values. There's no way in
hell you can willy-nilly just change them. And if you do change them,
and applications break, there is no way in hell you can then blame the
application.

Yes, I'm upset. Very upset. Why was the error value changed in the
first place? There was no reason given, and it was changed to a
completely idiotic value. And when applications - understandably -
broke, you start asking "why?"

If applications didn't care about specific error values, then it
wouldn't make sense to have more than one to begin with, and you
shouldn't care which one that was. But since applications *do* care,
and since we *do* have multiple error values, we stick to the old
ones, unless there are some *very* good reasons not to.

And those reasons really need to be very good, and spelled out and
explained. In this case, none of that was even remotely the case.

So your question "why would pulseaudio care" is totally *irrelevant*,
senseless, and has nothing to do with anything. Pulseaudio cares, and
caring fundamentally makes sense. It's questioning that obvious fact
that does not make sense!

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/