linux-kernel - Re: [Regression w/ patch] Media commit causes user space to misbahave (was: Re: Linux 3.8-rc1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121223120822.233282ba@redhat.com>
Date:	Sun, 23 Dec 2012 12:08:22 -0200
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Hans Verkuil <hans.verkuil@...co.com>
Subject: Re: [Regression w/ patch] Media commit causes user space to
 misbahave (was: Re: Linux 3.8-rc1)

Em Sun, 23 Dec 2012 14:39:32 +0100
"Rafael J. Wysocki" <rjw@...k.pl> escreveu:

> Hi Laurent,
> 
> Commit f0ed2ce ([media] uvcvideo: Set error_idx properly for extended
> controls API failures) of yours unfortunately causes user space to misbehave
> on one of my test systems.  Namely, there's no sound under KDE 4.9.4
> (Tumbleweed version using pulseaudio) and there's a knotify4 process occupying
> one of the CPU cores entirely 100% of the time.
> 
> I used the patch below to fix the problem for me.
> 
> Thanks,
> Rafael
> 
> 
> ---
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Subject: [media]: Revert part of commit f0ed2ce to fix user space breakage
> 
> Commit f0ed2ce ([media] uvcvideo: Set error_idx properly for extended
> controls API failures) causes user space to behave incorrectly on one
> of my test machines (there is no sound under KDE 4.9.4 using
> pulseaudio and there is a knotify4 process occupying one of the CPU
> cores 100% of the time).  Reverting that commit entirely fixes the
> problem for me.
> 
> However, commit f0ed2ce appears to do more than it follows from its
> changelog, because the changelog only says about the changes related
> to ctrls->error_idx, while the commit additionally changes error
> codes returned by various functions in uvc_ctrl.c and uvc_v4l2.c.  It
> turns out that the changes of the returned error codes confuse the
> user spce, so it is sufficient to revert the part of commit f0ed2ce
> not mentioned in its changelog to fix the problem.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/media/usb/uvc/uvc_ctrl.c |   19 ++++++++-----------
>  drivers/media/usb/uvc/uvc_v4l2.c |   12 +++++-------
>  2 files changed, 13 insertions(+), 18 deletions(-)
> 
> Index: linux/drivers/media/usb/uvc/uvc_ctrl.c
> ===================================================================
> --- linux.orig/drivers/media/usb/uvc/uvc_ctrl.c
> +++ linux/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -1061,7 +1061,7 @@ int uvc_query_v4l2_ctrl(struct uvc_video
>  
>  	ctrl = uvc_find_control(chain, v4l2_ctrl->id, &mapping);
>  	if (ctrl == NULL) {
> -		ret = -ENOENT;
> +		ret = -EINVAL;
>  		goto done;
>  	}
...

Rafael,

Are you saying that pulseaudio is entering on some weird loop if the
returned value is not -EINVAL? That seems a bug at pulseaudio.

Btw, why pulseaudio is even trying to access a V4L2 control? 
I would expect an audio application to take care of its own audio
business, and to not try to access other random Kernel APIs.

In other words, only an application that handles video should be
using those controls, and as far as I know, pulseaudio is not a
such application. Or are it trying to do world domination?

So, on a first glance, this doesn't sound like a regression, 
but, instead, it looks tha pulseaudio/tumbleweed has some serious
bugs and/or regressions.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/