linux-kernel - Re: [3.8-rc1] Networking problems after pulling-in net.git#master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUV4WEu6xp=-TyHH2z4Zcz8g0iHY2ZVk-jBJNt1azcXa2A@mail.gmail.com>
Date:	Sun, 23 Dec 2012 15:14:59 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Borislav Petkov <bp@...en8.de>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [3.8-rc1] Networking problems after pulling-in net.git#master

On Sun, Dec 23, 2012 at 2:44 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Sun, Dec 23, 2012 at 9:19 PM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>>
>> The culprit commit here seems to be...
>>
>> commit 9650388b5c56578fdccc79c57a8c82fb92b8e7f1
>> Author: Eric Dumazet <edumazet@...gle.com>
>> Date:   Fri Dec 21 07:32:10 2012 +0000
>>
>>     ipv4: arp: fix a lockdep splat in arp_solicit()
>
> Can you try the following one-line fix?
>
> Thanks.
>
> ------------>
>
> diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
> index 1169ed4..75e0d7c 100644
> --- a/net/ipv4/arp.c
> +++ b/net/ipv4/arp.c
> @@ -365,7 +365,7 @@ static void arp_solicit(struct neighbour *neigh,
> struct sk_buff *skb)
>                         pr_debug("trying to ucast probe in NUD_INVALID\n");
>                 neigh_ha_snapshot(dst_ha, neigh, dev);
>         } else {
> -               memset(dst_ha, 0, dev->addr_len);
> +               memcpy(dst_ha, dev->broadcast, MAX_ADDR_LEN);
>                 probes -= neigh->parms->app_probes;
>                 if (probes < 0) {
>  #ifdef CONFIG_ARPD

[ CCing Eric ]

YES, thie fixes my problem.
But your patch was somehow malformed, so I attached mine.

- Sedat -

Download attachment "0001-ipv4-arp-Fixup-to-commit-9650388b5c56578fdccc79c57a8.patch" of type "application/octet-stream" (869 bytes)