linux-kernel - [PATCH] mfd: twl4030: TWL4030_CORE needs REGMAP and REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1356354750-22969-1-git-send-email-omar.ramirez@copitl.com>
Date:	Mon, 24 Dec 2012 07:12:30 -0600
From:	Omar Ramirez Luna <omar.ramirez@...itl.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Chen Gang <gang.chen@...anux.com>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	Omar Ramirez Luna <omar.ramirez@...itl.com>
Subject: [PATCH] mfd: twl4030: TWL4030_CORE needs REGMAP and REGMAP_I2C

Selecting REGMAP_I2C defaults REGMAP to "y", no need to
explicitly select it.

This fixes:

- Because of REGMAP, a bunch of:
drivers/mfd/twl-core.c:221:29:
    error: array type has incomplete element type
drivers/mfd/twl-core.c:224:3:
    error: field name not in record or union initializer
drivers/mfd/twl-core.c:224:3:
    error: (near initialization for 'twl4030_regmap_config')

- Because of REGMAP_I2C:
drivers/mfd/twl-core.c: In function 'twl_probe':
drivers/mfd/twl-core.c:1256:3: error: implicit declaration of function
'devm_regmap_init_i2c' [-Werror=implicit-function-declaration]

Reported-by: Chen Gang <gang.chen@...anux.com>
Signed-off-by: Omar Ramirez Luna <omar.ramirez@...itl.com>
---
 drivers/mfd/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 1c0abd4..47ad4e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -292,6 +292,7 @@ config TWL4030_CORE
 	bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
 	depends on I2C=y && GENERIC_HARDIRQS
 	select IRQ_DOMAIN
+	select REGMAP_I2C
 	help
 	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
 	  This core driver provides register access and IRQ handling
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/