linux-kernel - Re: [PATCH] resubmit w1_therm:Retries:remove old code add CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121224184735.GA4143@ioremap.net>
Date:	Mon, 24 Dec 2012 22:47:35 +0400
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	david <david@...ncliff.com>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] resubmit  w1_therm:Retries:remove old code add CRC

Hi

Sorry for late reply - too much things to finish before the new year.

On Tue, Dec 18, 2012 at 01:37:56AM +0000, david (david@...ncliff.com) wrote:
> w1_therm includes some obsolete code to detect bad_roms, this is no
> longer relevant.
> The retry code is only used for this bad_rom test, however there is a
> CRC check that detects a bad read, but does not trigger a retry. This
> patch removes all the bad_rom code and uses the CRC check to trigger
> retries.
> 
> Signed-off-by: David Stevenson <david@...ncliff.com>

Greg, patch is ok, we discussed it in private with David
Please push it into your tree

Acked-by: Evgeniy Polyakov <zbr@...emap.net>

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/