linux-kernel - Re: Porting problem: ndo_set_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1356376587.20133.9693.camel@edumazet-glaptop>
Date:	Mon, 24 Dec 2012 11:16:27 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Woody Wu <narkewoody@...il.com>
Cc:	kernelnewbies@...nelnewbies.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: Porting problem: ndo_set_multicast_list removed

On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> Hi, list
> 
> I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> kernel, the ndo_set_multicast_list method in the net_device_ops had been
> removed. What's the story behind?  Can I simply ignore this method
> defined in an old driver?
> 
> Please also help to check the below code, is the list of the operations
> defined for my driver enough or not?
> 
> const struct net_device_ops ax_netdev_ops = {
> 	.ndo_open		= mydriver_open,
> 	.ndo_stop		= mydriver_close,
> 	.ndo_start_xmit		= mydriver_start_xmit,
> 	.ndo_get_stats		= mydriver_get_stats,
> 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> };
> 
> Thanks in advance.
> 

Take a look at :

commit afc4b13df143122f99a0eb10bfefb216c2806de0
Author: Jiri Pirko <jpirko@...hat.com>
Date:   Tue Aug 16 06:29:01 2011 +0000

    net: remove use of ndo_set_multicast_list in drivers
    
    replace it by ndo_set_rx_mode
    
    Signed-off-by: Jiri Pirko <jpirko@...hat.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/