linux-kernel - Re: [PATCH] rtc: add RTC driver for TPS80031/TPS80032

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAHdPZaPaOVoc8a3v_4+y3Cp1J9JRgyfeHQTJqvK-LbMnjrehDQ@mail.gmail.com>
Date:	Mon, 24 Dec 2012 16:01:47 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"akpm@...uxfoundation.org" <akpm@...uxfoundation.org>,
	"a.zummo@...ertech.it" <a.zummo@...ertech.it>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: add RTC driver for TPS80031/TPS80032

Hello,

On Mon, Dec 24, 2012 at 3:58 PM, Laxman Dewangan <ldewangan@...dia.com> wrote:
> Thanks Devendra for quick review.
>
> Following are my response specific to query.
>
> I will post the next patch for taking care of comments.
>
>

thanks :)

>
>
> On Monday 24 December 2012 03:32 PM, devendra.aaru wrote:
>>
>> Hello,
>>
>> On Mon, Dec 24, 2012 at 3:04 PM, Laxman Dewangan<ldewangan@...dia.com>
>> wrote:
>>>
>>> Add an RTC driver for TPS80031/TPS80032 chips by TI.
>>> This driver supports:
>>> - Setting and getting time and date.
>>> - Setting and reading alarm time.
>>> - Alarm and interrupt functionlity.
>>>
>>
>>> +
>>> +       if (alrm->enabled&&  (seconds<  epoch_start)) {
>>
>> its better to have this check in the core itself rather duplicating
>> everywhere, but i think the core already have this check, will you
>> please check ?
>
>
> Yes, it is there in __rtc_set_alarm() of interface.c file. I will remove
> this in next patch.
>

ok.

>
>
>>> +
>>> +static const struct dev_pm_ops tps80031_pm_ops = {
>>> +       SET_SYSTEM_SLEEP_PM_OPS(tps80031_rtc_suspend,
>>> tps80031_rtc_resume)
>>
>> say we dont have enabled CONFIG_PM_SLEEP, will we get an compiler error ?
>
>
> No compilation error. This is already taken care in on pm.h.
>

ok good to know, sorry for disturbing you with this comment.

>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/