linux-kernel - Re: [PATCH 19/29] batman-adv: fix random jitter calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyh1d9XxH2We4e2rjV-OYhbP2ObGC_iwrDeff2hphJ7TzQ@mail.gmail.com>
Date:	Wed, 26 Dec 2012 06:35:37 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Antonio Quartulli <ordex@...istici.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Marek Lindner <lindner_marek@...oo.de>,
	Simon Wunderlich <siwu@....tu-chemnitz.de>,
	b.a.t.m.a.n@...ts.open-mesh.org,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 19/29] batman-adv: fix random jitter calculation

2012/12/25 Antonio Quartulli <ordex@...istici.org>:
> On Mon, Dec 24, 2012 at 11:14:06AM +0900, Akinobu Mita wrote:
>> batadv_iv_ogm_emit_send_time() attempts to calculates a random integer
>> in the range of 'orig_interval +- BATADV_JITTER' by the below lines.
>>
>>         msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER;
>>         msecs += (random32() % 2 * BATADV_JITTER);
>>
>> But it actually gets 'orig_interval' or 'orig_interval - BATADV_JITTER'
>> because '%' and '*' have same precedence and associativity is
>> left-to-right.
>>
>> This adds the parentheses at the appropriate position so that it matches
>> original intension.
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
>> Cc: Marek Lindner <lindner_marek@...oo.de>
>> Cc: Simon Wunderlich <siwu@....tu-chemnitz.de>
>> Cc: Antonio Quartulli <ordex@...istici.org>
>> Cc: b.a.t.m.a.n@...ts.open-mesh.org
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: netdev@...r.kernel.org
>> ---
>
> Acked-by: Antonio Quartulli <ordex@...istici.org>
>
> But I would suggest to apply this change to net, since it is a fix.

I agree.
David, please consider to apply this patch for 3.8-rc*.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/