lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <50DB616D.50607@kernel.dk> Date: Wed, 26 Dec 2012 21:43:25 +0100 From: Jens Axboe <axboe@...nel.dk> To: majianpeng <majianpeng@...il.com> CC: Shaohua Li <shli@...nel.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] block: Remove should_sort judgement when flush blk_plug. On 2012-12-25 10:27, majianpeng wrote: > In commit 975927b942c932,it add blk_rq_pos to sort rq when flushing. > Although this commit was used for the situation which blk_plug handled > multi devices on the same time like md device. > I think there must be some situations like this but only single > device. > So remove the should_sort judgement. > Because the parameter should_sort is only for this purpose,it can delete > should_sort from blk_plug. Agree with the patch. It does not make sense to have ->should_sort and not set it for all the conditions that the list_sort() compare now checks for. Applied for 3.9, thanks. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists