| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1212262145220.23814@swampdragon.chaosbits.net> Date: Wed, 26 Dec 2012 21:51:12 +0100 (CET) From: Jesper Juhl <jj@...osbits.net> To: linux-kernel@...r.kernel.org cc: wlanfae <wlanfae@...ltek.com>, netdev@...r.kernel.org, linux-wireless@...r.kernel.org, "John W. Linville" <linville@...driver.com>, Chaoming Li <chaoming_li@...lsil.com.cn>, Larry Finger <Larry.Finger@...inger.net> Subject: [PATCH] rtlwifi: Don't leak on error in _rtl_usb_receive() We fail to release 'urb' if '_rtl_prep_rx_urb()' fails in _rtl_usb_receive(). This patch should take care of the leak. Signed-off-by: Jesper Juhl <jj@...osbits.net> --- drivers/net/wireless/rtlwifi/usb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) note: compile tested only. diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c index 29f0969..75c29e6 100644 --- a/drivers/net/wireless/rtlwifi/usb.c +++ b/drivers/net/wireless/rtlwifi/usb.c @@ -640,6 +640,7 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw) RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, "Failed to prep_rx_urb!!\n"); err = PTR_ERR(skb); + usb_free_urb(urb); goto err_out; } -- 1.7.1 -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists