lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20121226.151355.2215825989495032073.davem@davemloft.net> Date: Wed, 26 Dec 2012 15:13:55 -0800 (PST) From: David Miller <davem@...emloft.net> To: paolo.valente@...more.it Cc: jhs@...atatu.com, shemminger@...tta.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, rizzo@....unipi.it, fchecconi@...il.com Subject: Re: [PATCH BUGFIX] pkt_sched: fix little service anomalies and possible crashes of qfq+ From: Paolo valente <paolo.valente@...more.it> Date: Wed, 19 Dec 2012 18:31:06 +0100 > + /* > + * The next assignment may let > + * agg->initial_budget > agg->budgetmax > + * hold, but this does not cause any harm > + */ Please format comments in the networking: /* Like * this. */ and /* * Never * like this. */ I know this file is full of exceptions, but that error is to be corrected rather than expanded. > + /* > + * If lmax is lowered, through qfq_change_class, for a class > + * owning pending packets with larger size than the new value of lmax, > + * then the following condition may hold. > + */ Likewise. And I'm not applying this until someone familiar with this code does some review of this patch. These are seriously non-trivial changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists