lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <50DA6D1E.1010209@cn.fujitsu.com> Date: Wed, 26 Dec 2012 11:21:02 +0800 From: Tang Chen <tangchen@...fujitsu.com> To: Jianguo Wu <wujianguo@...wei.com> CC: akpm@...ux-foundation.org, rientjes@...gle.com, liuj97@...il.com, len.brown@...el.com, benh@...nel.crashing.org, paulus@...ba.org, cl@...ux.com, minchan.kim@...il.com, kosaki.motohiro@...fujitsu.com, isimatu.yasuaki@...fujitsu.com, wency@...fujitsu.com, hpa@...or.com, linfeng@...fujitsu.com, laijs@...fujitsu.com, mgorman@...e.de, yinghai@...nel.org, x86@...nel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-acpi@...r.kernel.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, linux-ia64@...r.kernel.org, cmetcalf@...era.com, sparclinux@...r.kernel.org Subject: Re: [PATCH v5 06/14] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap On 12/25/2012 04:09 PM, Jianguo Wu wrote: >> + >> + if (!cpu_has_pse) { >> + next = (addr + PAGE_SIZE)& PAGE_MASK; >> + pmd = pmd_offset(pud, addr); >> + if (pmd_none(*pmd)) >> + continue; >> + get_page_bootmem(section_nr, pmd_page(*pmd), >> + MIX_SECTION_INFO); >> + >> + pte = pte_offset_kernel(pmd, addr); >> + if (pte_none(*pte)) >> + continue; >> + get_page_bootmem(section_nr, pte_page(*pte), >> + SECTION_INFO); >> + } else { >> + next = pmd_addr_end(addr, end); >> + >> + pmd = pmd_offset(pud, addr); >> + if (pmd_none(*pmd)) >> + continue; >> + get_page_bootmem(section_nr, pmd_page(*pmd), >> + SECTION_INFO); > > Hi Tangļ¼ > In this case, pmd maps 512 pages, but you only get_page_bootmem() on the first page. > I think the whole 512 pages should be get_page_bootmem(), what do you think? > Hi Wu, Yes, thanks. I will fix it. :) Thanks. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists