linux-kernel - Re: [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Dec 2012 11:49:29 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Matt Sealey <matt@...esi-usa.com>
Cc:	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack

On Sun, Dec 23, 2012 at 05:16:02AM -0600, Matt Sealey wrote:
> Since Efika MX platform support (pre-devicetree) was removed from the tree
> this code no longer has any possibility of running and clutters up the
> driver which is being replaced by the chipidea host in the future anyway.
> 
> Signed-off-by: Matt Sealey <matt@...esi-usa.com>
> Tested-by: Steev Klimazewski <steev@...esi-usa.com>
> CC: Sascha Hauer <kernel@...gutronix.de>
> CC: Alan Stern <stern@...land.harvard.edu>

Acked-by: Sascha Hauer <s.hauer@...gutronix.de>


> 
> ---
>  drivers/usb/host/ehci-mxc.c |   20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index 8e58a5f..b62c3a8 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -102,7 +102,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
>  	struct usb_hcd *hcd;
>  	struct resource *res;
>  	int irq, ret;
> -	unsigned int flags;
>  	struct ehci_mxc_priv *priv;
>  	struct device *dev = &pdev->dev;
>  	struct ehci_hcd *ehci;
> @@ -213,25 +212,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_add;
>  
> -	if (pdata->otg) {
> -		/*
> -		 * efikamx and efikasb have some hardware bug which is
> -		 * preventing usb to work unless CHRGVBUS is set.
> -		 * It's in violation of USB specs
> -		 */
> -		if (machine_is_mx51_efikamx() || machine_is_mx51_efikasb()) {
> -			flags = usb_phy_io_read(pdata->otg,
> -							ULPI_OTG_CTRL);
> -			flags |= ULPI_OTG_CTRL_CHRGVBUS;
> -			ret = usb_phy_io_write(pdata->otg, flags,
> -							ULPI_OTG_CTRL);
> -			if (ret) {
> -				dev_err(dev, "unable to set CHRVBUS\n");
> -				goto err_add;
> -			}
> -		}
> -	}
> -
>  	return 0;
>  
>  err_add:
> -- 
> 1.7.10.4
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/