linux-kernel - Re: [PATCH 2/2] USB: ehci-s5p: Add to get interrupt from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Dec 2012 20:58:10 +0900
From:	Dongjin Kim <tobetter@...il.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	linux-samsung-soc@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] USB: ehci-s5p: Add to get interrupt from DT

Hi Sergei,

Yes, you are right.
I made this patch to read its interrupt number from dtb directly. But
now platform_get_irq() returns correct irq since "OF_DEV_AUXDATA(...)"
is added as my first patch.

This patch is useless.

Thanks and best regards,
Dongjin.

On Thu, Dec 27, 2012 at 5:18 AM, Sergei Shtylyov <sshtylyov@...sta.com> wrote:
>
> Hello.
>
> On 12/26/2012 09:42 PM, Dongjin Kim wrote:
>
> > This patch support to get interrupt resource from device tree as well as
> > platform device if ehci node is defined in device tree and it's irq is
> > described.
>
> > Signed-off-by: Dongjin Kim <tobetter@...il.com>
> > ---
> >  drivers/usb/host/ehci-s5p.c |    8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
>
> > diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> > index 319dcfa..0fc5e5e 100644
> > --- a/drivers/usb/host/ehci-s5p.c
> > +++ b/drivers/usb/host/ehci-s5p.c
> > @@ -16,6 +16,7 @@
> >  #include <linux/of.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/of_gpio.h>
> > +#include <linux/of_irq.h>
> >  #include <linux/platform_data/usb-ehci-s5p.h>
> >  #include <plat/usb-phy.h>
> >
> > @@ -156,7 +157,12 @@ static int s5p_ehci_probe(struct platform_device
> > *pdev)
> >               goto fail_io;
> >       }
> >
> > -     irq = platform_get_irq(pdev, 0);
> > +     if (pdev->dev.of_node)
> > +             irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
>
>    platform_get_irq() should still work for device tree based platform
> devices.
> I don't see the point on the patch?
>
> > +     else {
> > +             irq = platform_get_irq(pdev, 0);
> > +     }
>
>    Hm, why {} out of the blue? Both arms of *if* are single-stratement.
>
> > +
>
>    No need for empty line here.
>
> >       if (!irq) {
> >               dev_err(&pdev->dev, "Failed to get IRQ\n");
> >               err = -ENODEV;
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/