linux-kernel - Re: [tip] config: Add 'make kvmconfig'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50DB9FA5.6070704@infradead.org>
Date:	Wed, 26 Dec 2012 17:08:53 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	David Rientjes <rientjes@...gle.com>,
	Sasha Levin <levinsasha928@...il.com>,
	Michal Marek <mmarek@...e.cz>, Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [tip] config: Add 'make kvmconfig'

On 12/26/12 15:32, David Woodhouse wrote:
> On Tue, 2012-12-25 at 22:32 -0800, David Rientjes wrote:
>>
>> This creates quite a few build failures on auto-latest:
>>
>> arch/x86/built-in.o: In function `hpet_setup_msi_irq':
>> hpet.c:(.text+0x34638): undefined reference to `arch_setup_hpet_msi'
>> hpet.c:(.text+0x34651): undefined reference to `destroy_irq'
>> arch/x86/built-in.o: In function `hpet_msi_capability_lookup':
>> hpet.c:(.text+0x347ff): undefined reference to `create_irq_nr'
>> arch/x86/built-in.o:(.data+0xd1c): undefined reference to `native_setup_msi_irqs'
>> arch/x86/built-in.o:(.data+0xd20): undefined reference to `native_teardown_msi_irq'

I reported these build errors in linux-next on Nov. 7, 2011 !!!

> This one is actually caused by commit 3b08ed026 (config: Add 'make
> kvmconfig'), which selects PCI_MSI even on a 32-bit config where it's
> invalid to do so.
> 
> Ew, that commit seems like a *completely* wrong-headed idea. That abuse
> of 'select' is just begging for this kind of breakage. We have other
> ways to merge configs and turn certain options on, without doing it this
> way.

but I didn't diagnose the problem.  Thanks for that.

Yes, 'make kvmconfig' takes liberties and shortcuts.  :(

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/